linux-kernel - Re: [PATCH V2 5/6] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150727171618.GB20509@krava.brq.redhat.com>
Date:	Mon, 27 Jul 2015 19:16:18 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	"Liang, Kan" <kan.liang@...el.com>
Cc:	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"acme@...nel.org" <acme@...nel.org>,
	"luto@...nel.org" <luto@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"eranian@...gle.com" <eranian@...gle.com>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"Hunter, Adrian" <adrian.hunter@...el.com>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"namhyung@...nel.org" <namhyung@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 5/6] perf,tools: caculate and save
 freq/CPU%/CORE_BUSY% in he_stat

On Mon, Jul 27, 2015 at 05:11:13PM +0000, Liang, Kan wrote:
> > 
> > On Fri, Jul 24, 2015 at 09:48:31AM -0400, kan.liang@...el.com wrote:
> > 
> > SNIP
> > 
> > >  				      struct addr_location *al,
> > > @@ -109,6 +110,7 @@ struct hist_entry *__hists__add_entry(struct
> > hists *hists,
> > >  				      struct branch_info *bi,
> > >  				      struct mem_info *mi, u64 period,
> > >  				      u64 weight, u64 transaction,
> > > +				      struct freq_perf_info *freq_perf,
> > >  				      bool sample_self);
> > >  int hist_entry_iter__add(struct hist_entry_iter *iter, struct
> > addr_location *al,
> > >  			 int max_stack_depth, void *arg);
> > > diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h index
> > > e97cd47..90422ed 100644
> > > --- a/tools/perf/util/sort.h
> > > +++ b/tools/perf/util/sort.h
> > > @@ -54,6 +54,9 @@ struct he_stat {
> > >  	u64			period_guest_us;
> > >  	u64			weight;
> > >  	u32			nr_events;
> > > +	u64			freq;
> > > +	u64			cpu_u;
> > 
> > could the cpu_u have more descriptive name?
> 
> How about "cpu_util" or "cpu_utilization"?

cpu_util sounds good to me

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/