| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Jul 2015 21:41:12 -0700
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompiling@...il.com>
To: Larry Finger <Larry.Finger@...inger.net>,
Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Nitin Kuppelur <nitinkuppelur@...il.com>,
Joshua Clayton <stillcompiling@...il.com>,
Vaishali Thakkar <vthakkar1994@...il.com>,
Tapasweni Pathak <tapaswenipathak@...il.com>,
Daniel Baluta <daniel.baluta@...el.com>,
Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
Max Perepelitsyn <mperepelitsyn@...il.com>,
Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
Cristina Opriceana <cristina.opriceana@...il.com>,
Dogukan Ergun <dogukan.ergun@...il.com>,
Julia Lawall <Julia.Lawall@...6.fr>,
Dan Carpenter <dan.carpenter@...cle.com>,
Haneen Mohammed <hamohammed.sa@...il.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: [PATCH V3 3/8] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 21:41:12 -0700
Message-Id: <f399f91588288cd11d2850a0bb784f29606d216a.1438057939.git.stillcompiling@...il.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
References: <cover.1438057939.git.stillcompiling@...il.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
---
drivers/staging/rtl8712/wlan_bssdef.h | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists