linux-kernel - Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B7F035.6010201@citrix.com>
Date:	Tue, 28 Jul 2015 22:12:21 +0100
From:	Andrew Cooper <andrew.cooper3@...rix.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	Julien Grall <julien.grall@...rix.com>,
	<xen-devel@...ts.xenproject.org>
CC:	<linux-fbdev@...r.kernel.org>, <x86@...nel.org>,
	<netdev@...r.kernel.org>, Jiri Slaby <jslaby@...e.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Russell King" <linux@....linux.org.uk>,
	<linux-scsi@...r.kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	<stefano.stabellini@...citrix.com>, Ingo Molnar <mingo@...hat.com>,
	<linux-input@...r.kernel.org>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	<ian.campbell@...rix.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	"Juergen Gross" <jgross@...e.com>, Wei Liu <wei.liu2@...rix.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	<linux-kernel@...r.kernel.org>,
	David Vrabel <david.vrabel@...rix.com>,
	<linux-api@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	Roger Pau Monné <roger.pau@...rix.com>
Subject: Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies
 in Linux

On 28/07/15 22:06, H. Peter Anvin wrote:
> On 07/28/2015 08:02 AM, Julien Grall wrote:
>> Hi all,
>>
>> This patch series aims to use the memory terminologies described in
>> include/linux/mm.h [1] for Linux xen code.
>>
>> Linux is using mistakenly MFN when GFN is meant, I suspect this is because the
>> first support of Xen was for PV. This has brought some misimplementation
>> of memory helpers on ARM and make the developper confused about the expected
>> behavior.
>>
>> For instance, with pfn_to_mfn, we expect to get a MFN based on the name.
>> Although, if we look at the implementation on x86, it's returning a GFN.
>> Most of the callers are also using it this way.
>>
>> The first 2 patches of this series is ARM related in order to remove
>> PV specific helpers which should not be used and fixing the implementation of
>> pfn_to_mfn.
>>
>> The rest of the series is here rename most of the usage in the common code
>> of MFN to GFN. I also took the opportunity to replace most of the call to
>> pfn_to_gfn in the common code by page_to_gfn avoid construction such
>> as pfn_to_gfn(page_to_pfn(...).
>>
>> Note the one xen-blkfront will be dropped by 64K series [2], I can include it
>> if necessary.
>>
> Can we actually get some documentation for Xen before starting to change
> names around?

http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb

~Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/