| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Jul 2015 07:27:53 +0200 (CEST) From: Julia Lawall <julia.lawall@...6.fr> To: Joshua Clayton <stillcompiling@...il.com> cc: Larry Finger <Larry.Finger@...inger.net>, Florian Schilhabel <florian.c.schilhabel@...glemail.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Sudip Mukherjee <sudipm.mukherjee@...il.com>, Nitin Kuppelur <nitinkuppelur@...il.com>, Vaishali Thakkar <vthakkar1994@...il.com>, Tapasweni Pathak <tapaswenipathak@...il.com>, Daniel Baluta <daniel.baluta@...el.com>, Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, Max Perepelitsyn <mperepelitsyn@...il.com>, Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, Cristina Opriceana <cristina.opriceana@...il.com>, Dogukan Ergun <dogukan.ergun@...il.com>, Julia Lawall <Julia.Lawall@...6.fr>, Dan Carpenter <dan.carpenter@...cle.com>, Haneen Mohammed <hamohammed.sa@...il.com>, Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V3 0/8] clean up wlan_bssdef.h Something horrible seems to have happened in your patch sending process, and you have the same message over and over. Also, you don't really need to seen the patch to everyone who has ever touched the file. The following arguments can be useful: --nokeywords --nogit --nogit-fallback --norolestats julia On Mon, 27 Jul 2015, Joshua Clayton wrote: > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > From: Joshua Clayton <stillcompiling@...il.com> > To: Larry Finger <Larry.Finger@...inger.net>, > Florian Schilhabel <florian.c.schilhabel@...glemail.com>, > Greg Kroah-Hartman <gregkh@...uxfoundation.org>, > Sudip Mukherjee <sudipm.mukherjee@...il.com>, > Nitin Kuppelur <nitinkuppelur@...il.com>, > Joshua Clayton <stillcompiling@...il.com>, > Vaishali Thakkar <vthakkar1994@...il.com>, > Tapasweni Pathak <tapaswenipathak@...il.com>, > Daniel Baluta <daniel.baluta@...el.com>, > Melike Yurtoglu <aysemelikeyurtoglu@...il.com>, > Max Perepelitsyn <mperepelitsyn@...il.com>, > Aya Mahfouz <mahfouz.saif.elyazal@...il.com>, > Cristina Opriceana <cristina.opriceana@...il.com>, > Dogukan Ergun <dogukan.ergun@...il.com>, > Julia Lawall <Julia.Lawall@...6.fr>, > Dan Carpenter <dan.carpenter@...cle.com>, > Haneen Mohammed <hamohammed.sa@...il.com>, > Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> > Cc: devel@...verdev.osuosl.org, > linux-kernel@...r.kernel.org > Subject: [PATCH V3 0/8] clean up wlan_bssdef.h > Date: Mon, 27 Jul 2015 21:41:09 -0700 > Message-Id: <cover.1438057939.git.stillcompiling@...il.com> > X-Mailer: git-send-email 2.4.6 > > The main goal of this series is to get rid of a needless typedef > in the rtl8712 wlan driver. > > In the course of fixing that, I found a bug that can (at least in theory) > lead to a overrun during a memcpy, as well as an identical struct with > a different name, which use the typedef. > Finally after cleaning up the typedef, change the name of the primary > variable that used the typedef from "SupportedRates" to "rates", to > conform to kernel coding style. > > Changes since V1: > Do not make other logic changes while Changing the name of SupportedRates > New patch 3/6 fixes a buggy comment that referred to the typedef > > Changes sinve V2: > broke former patch 4, which was too big for git-send-email into 3 parts > > Joshua Clayton (8): > staging: rtl8712: fix buggy size calculation > staging: rtl8712: simplify size calculation > staging: rtl8712: fix comment > staging: rtl8712: removed unused wrapper structs > staging: rtl8712: remove duplicate struct > staging: rtl8712: rename function > staging: rtl8712: remove typedefs > staging: rtl8712: change SupportedRates to rates > > drivers/staging/rtl8712/ieee80211.c | 22 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.c | 28 +++++----------- > drivers/staging/rtl8712/rtl871x_cmd.h | 18 ---------- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 36 ++++++++++---------- > drivers/staging/rtl8712/rtl871x_mlme.c | 47 ++++++++++----------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++-- > drivers/staging/rtl8712/wlan_bssdef.h | 42 +++--------------------- > 9 files changed, 64 insertions(+), 139 deletions(-) > > -- > 2.4.6 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists