linux-kernel - Re: [patch 4/9] mfd/pm8921: Consolidate chained IRQ handler install/remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150728080513.GE14943@x1>
Date:	Tue, 28 Jul 2015 09:05:13 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Julia Lawall <Julia.Lawall@...6.fr>
Subject: Re: [patch 4/9] mfd/pm8921: Consolidate chained IRQ handler
 install/remove

On Mon, 13 Jul 2015, Thomas Gleixner wrote:

> Chained irq handlers usually set up handler data as well. We now have
> a function to set both under irq_desc->lock. Replace the two calls
> with one.
> 
> Reported-by: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Julia Lawall <Julia.Lawall@...6.fr>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mfd/pm8921-core.c |    9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Applied, thanks.

> Index: tip/drivers/mfd/pm8921-core.c
> ===================================================================
> --- tip.orig/drivers/mfd/pm8921-core.c
> +++ tip/drivers/mfd/pm8921-core.c
> @@ -336,14 +336,12 @@ static int pm8921_probe(struct platform_
>  	if (!chip->irqdomain)
>  		return -ENODEV;
>  
> -	irq_set_handler_data(irq, chip);
> -	irq_set_chained_handler(irq, pm8xxx_irq_handler);
> +	irq_set_chained_handler_and_data(irq, pm8xxx_irq_handler, chip);
>  	irq_set_irq_wake(irq, 1);
>  
>  	rc = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
>  	if (rc) {
> -		irq_set_chained_handler(irq, NULL);
> -		irq_set_handler_data(irq, NULL);
> +		irq_set_chained_handler_and_data(irq, NULL, NULL);
>  		irq_domain_remove(chip->irqdomain);
>  	}
>  
> @@ -362,8 +360,7 @@ static int pm8921_remove(struct platform
>  	struct pm_irq_chip *chip = platform_get_drvdata(pdev);
>  
>  	device_for_each_child(&pdev->dev, NULL, pm8921_remove_child);
> -	irq_set_chained_handler(irq, NULL);
> -	irq_set_handler_data(irq, NULL);
> +	irq_set_chained_handler_and_data(irq, NULL, NULL);
>  	irq_domain_remove(chip->irqdomain);
>  
>  	return 0;
> 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/