linux-kernel - Re: [patch 9/9] mfd/max899x: Avoid redundant irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 09:06:13 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [patch 9/9] mfd/max899x: Avoid redundant irq_data lookup

On Mon, 13 Jul 2015, Thomas Gleixner wrote:

> It's pretty silly to do
> 
>      irq_data *d = irq_get_irq_data(irq_data->irq);
> 
> because that results in d = irq_data, but goes through a lookup of the
> irq_data. Use irq_data directly.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Jiang Liu <jiang.liu@...ux.intel.com>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> ---
>  drivers/mfd/max8997-irq.c |    7 +++----
>  drivers/mfd/max8998-irq.c |    9 +++------
>  2 files changed, 6 insertions(+), 10 deletions(-)

Applied, thanks.

> Index: tip/drivers/mfd/max8997-irq.c
> ===================================================================
> --- tip.orig/drivers/mfd/max8997-irq.c
> +++ tip/drivers/mfd/max8997-irq.c
> @@ -140,9 +140,8 @@ static void max8997_irq_sync_unlock(stru
>  }
>  
>  static const inline struct max8997_irq_data *
> -irq_to_max8997_irq(struct max8997_dev *max8997, int irq)
> +irq_to_max8997_irq(struct max8997_dev *max8997, struct irq_data *data)
>  {
> -	struct irq_data *data = irq_get_irq_data(irq);
>  	return &max8997_irqs[data->hwirq];
>  }
>  
> @@ -150,7 +149,7 @@ static void max8997_irq_mask(struct irq_
>  {
>  	struct max8997_dev *max8997 = irq_data_get_irq_chip_data(data);
>  	const struct max8997_irq_data *irq_data = irq_to_max8997_irq(max8997,
> -								data->irq);
> +								     data);
>  
>  	max8997->irq_masks_cur[irq_data->group] |= irq_data->mask;
>  }
> @@ -159,7 +158,7 @@ static void max8997_irq_unmask(struct ir
>  {
>  	struct max8997_dev *max8997 = irq_data_get_irq_chip_data(data);
>  	const struct max8997_irq_data *irq_data = irq_to_max8997_irq(max8997,
> -								data->irq);
> +								     data);
>  
>  	max8997->irq_masks_cur[irq_data->group] &= ~irq_data->mask;
>  }
> Index: tip/drivers/mfd/max8998-irq.c
> ===================================================================
> --- tip.orig/drivers/mfd/max8998-irq.c
> +++ tip/drivers/mfd/max8998-irq.c
> @@ -98,9 +98,8 @@ static struct max8998_irq_data max8998_i
>  };
>  
>  static inline struct max8998_irq_data *
> -irq_to_max8998_irq(struct max8998_dev *max8998, int irq)
> +irq_to_max8998_irq(struct max8998_dev *max8998, struct irq_data *data)
>  {
> -	struct irq_data *data = irq_get_irq_data(irq);
>  	return &max8998_irqs[data->hwirq];
>  }
>  
> @@ -134,8 +133,7 @@ static void max8998_irq_sync_unlock(stru
>  static void max8998_irq_unmask(struct irq_data *data)
>  {
>  	struct max8998_dev *max8998 = irq_data_get_irq_chip_data(data);
> -	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998,
> -							       data->irq);
> +	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998, data);
>  
>  	max8998->irq_masks_cur[irq_data->reg - 1] &= ~irq_data->mask;
>  }
> @@ -143,8 +141,7 @@ static void max8998_irq_unmask(struct ir
>  static void max8998_irq_mask(struct irq_data *data)
>  {
>  	struct max8998_dev *max8998 = irq_data_get_irq_chip_data(data);
> -	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998,
> -							       data->irq);
> +	struct max8998_irq_data *irq_data = irq_to_max8998_irq(max8998, data);
>  
>  	max8998->irq_masks_cur[irq_data->reg - 1] |= irq_data->mask;
>  }
> 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/