linux-kernel - Re: [PATCH v2 01/16] MIPS: remove outdated comments in sigcontext.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150728083905.GE30938@linux-mips.org>
Date:	Tue, 28 Jul 2015 10:39:05 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Paul Burton <paul.burton@...tec.com>
Cc:	linux-mips@...ux-mips.org, Guenter Roeck <linux@...ck-us.net>,
	Matthew Fortune <matthew.fortune@...tec.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/16] MIPS: remove outdated comments in sigcontext.h

On Mon, Jul 27, 2015 at 12:58:12PM -0700, Paul Burton wrote:

> The offsets to various fields within struct sigcontext are declared
> using asm-offsets.c these days, so drop the outdated comment that talks
> about keeping in sync with a no longer present file.

The file was renamed not removed and the comment still applies.  I've
recently fixed the comment so this patch again is against would reject
aside of being wrong so I'm dropping it.

> diff --git a/arch/mips/include/uapi/asm/sigcontext.h b/arch/mips/include/uapi/asm/sigcontext.h
> index 6c9906f..ae78902 100644
> --- a/arch/mips/include/uapi/asm/sigcontext.h
> +++ b/arch/mips/include/uapi/asm/sigcontext.h
> @@ -14,10 +14,6 @@
>  
>  #if _MIPS_SIM == _MIPS_SIM_ABI32
>  
> -/*
> - * Keep this struct definition in sync with the sigcontext fragment
> - * in arch/mips/tools/offset.c
> - */
>  struct sigcontext {
>  	unsigned int		sc_regmask;	/* Unused */
>  	unsigned int		sc_status;	/* Unused */
> @@ -45,9 +41,6 @@ struct sigcontext {
>  
>  #include <linux/posix_types.h>
>  /*
> - * Keep this struct definition in sync with the sigcontext fragment
> - * in arch/mips/tools/offset.c
> - *

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/