linux-kernel - RE: [PATCH 2/5] Documentation: Detail permitted DT properties for the imx6ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 08:48:08 +0000
From:	Chen Bough <Haibo.Chen@...escale.com>
To:	Mark Rutland <mark.rutland@....com>
CC:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"hans.verkuil@...co.com" <hans.verkuil@...co.com>,
	"hadess@...ess.net" <hadess@...ess.net>,
	"mchehab@....samsung.com" <mchehab@....samsung.com>,
	"mamlinav@...il.com" <mamlinav@...il.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"jonathar@...adcom.com" <jonathar@...adcom.com>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"christian.gmeiner@...il.com" <christian.gmeiner@...il.com>,
	"scott.liu@....com.tw" <scott.liu@....com.tw>,
	"geert@...ux-m68k.org" <geert@...ux-m68k.org>,
	"benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
	"sebastien.szymanski@...adeus.com" <sebastien.szymanski@...adeus.com>,
	"sbranden@...adcom.com" <sbranden@...adcom.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: RE: [PATCH 2/5] Documentation: Detail permitted DT properties for the
 imx6ul_tsc

Hi Mark,



> -----Original Message-----
> From: Mark Rutland [mailto:mark.rutland@....com]
> Sent: Monday, July 27, 2015 7:26 PM
> To: Chen Haibo-B51421
> Cc: robh+dt@...nel.org; Pawel Moll; ijc+devicetree@...lion.org.uk;
> galak@...eaurora.org; shawnguo@...nel.org; kernel@...gutronix.de;
> linux@....linux.org.uk; dmitry.torokhov@...il.com; hans.verkuil@...co.com;
> hadess@...ess.net; mchehab@....samsung.com; mamlinav@...il.com;
> arnd@...db.de; jonathar@...adcom.com; hdegoede@...hat.com;
> christian.gmeiner@...il.com; scott.liu@....com.tw; geert@...ux-m68k.org;
> benjamin.tissoires@...hat.com; sebastien.szymanski@...adeus.com;
> sbranden@...adcom.com; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> input@...r.kernel.org
> Subject: Re: [PATCH 2/5] Documentation: Detail permitted DT properties
> for the imx6ul_tsc
> 
> On Mon, Jul 27, 2015 at 12:26:44PM +0100, Haibo Chen wrote:
> > Here we apply required documentation for the imx6ul touch screen
> > controller driver which describe available properties and how to use
> > them.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@...escale.com>
> > ---
> >  .../devicetree/bindings/input/touchscreen/imx6ul_tsc.txt   | 14
> ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> > b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.txt
> > new file mode 100644
> > index 0000000..e34d752
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/imx6ul_tsc.t
> > +++ xt
> > @@ -0,0 +1,14 @@
> > +* Freescale i.MX6UL Touch Controller
> > +
> > +Required properties:
> > +- compatible: must be "fsl,imx6ul-tsc"
> > +
> 
> What about all the other properties in the example?

[haibo] I will add other properties in the documentation. 

> 
> > +Example:
> > +	&tsc {
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_tsc>;
> > +		status = "okay";
> > +		xnur-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> > +		measure_delay_time = <0xfff>;
> > +		pre_charge_time = <0xffff>;
> 
> Thiose underscores should be dashes, and all the properties should be
> documented.

[haibo] I will change to "measure-delay-time" and "pre-charge-time"

Thanks for your review!

Haibo.

> 
> Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/