linux-kernel - Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150728101525.GC5180@mwanda>
Date:	Tue, 28 Jul 2015 13:15:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jignesh R Patel <jigneshpatel0103@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Riley Andrews <riandrews@...roid.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding
 style problem

The subject isn't right.  You aren't patch checkpatch.pl itself you're
patching android.

The version doesn't go in the subject.

The subject is too vague.

On Tue, Jul 28, 2015 at 03:28:33PM +0530, Jignesh R Patel wrote:
> From: Jignesh R Patel <jigneshpatel0103@...il.com>

Not needed.

> 
> This patch fix coding style problem of more then
> 80 character in one line. This patch does not change any
> logic.
> 
> Signed-off-by: Jignesh R Patel <jigneshpatel0103@...il.com>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index 86b91fd..4a9a7bd 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!info->table)
>  		goto free_mem;
>  
> -	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len))
> +	if (dma_get_sgtable(dev, info->table, info->cpu_addr,
> +						info->handle, len))

This isn't the right way to do it.  I suppose the right thing is:

	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle,
			    len))

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/