linux-kernel - Re: [PATCH v2 3/5] staging: lustre: fix bad alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 17:05:54 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Mario Bambagini <mario.bambagini@...il.com>
Cc:	oleg.drokin@...el.com, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, andreas.dilger@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] staging: lustre: fix bad alignment

On Mon, Jul 27, 2015 at 09:20:23PM +0200, Mario Bambagini wrote:
> This patch fixes 8 bad alignments. When a line is split on
> more than one line, the other lines must be aligned with
> paranthesis.
> 
> Signed-off-by: Mario Bambagini <mario.bambagini@...il.com>
> ---
>  drivers/staging/lustre/lustre/llite/llite_capa.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
> index 1f72066..a3b3c46 100644
> --- a/drivers/staging/lustre/lustre/llite/llite_capa.c
> +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
> @@ -71,7 +71,7 @@ static unsigned long long ll_capa_renewal_retries;
>  static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa);
>  
>  static inline void update_capa_timer(struct obd_capa *ocapa,
> -							   unsigned long expiry)
> +				     unsigned long expiry)
This bad alignment was created in your previous patch of the series. You
should have aligned it when you splitted the line for 80 char limit.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/