linux-kernel - Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150728114656.GF15027@sudip-pc>
Date:	Tue, 28 Jul 2015 17:16:56 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Joshua Clayton <stillcompiling@...il.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Nitin Kuppelur <nitinkuppelur@...il.com>,
	Vaishali Thakkar <vthakkar1994@...il.com>,
	Tapasweni Pathak <tapaswenipathak@...il.com>,
	Daniel Baluta <daniel.baluta@...el.com>,
	Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
	Max Perepelitsyn <mperepelitsyn@...il.com>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	Dogukan Ergun <dogukan.ergun@...il.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Haneen Mohammed <hamohammed.sa@...il.com>,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation

On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote:
> r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> where the underlying struct has a 6 * unsigned char.
> Simplify the calculation by just subtracting the variable part from
> the size of the struct.
> 
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> 
> Signed-off-by: Joshua Clayton <stillcompiling@...il.com>
> ---
<snip>
>  
>  u8 *r8712_get_capability_from_ie(u8 *ie)
> -- 
> 2.4.6
> 
> From: Joshua Clayton <stillcompiling@...il.com>
> To: Larry Finger <Larry.Finger@...inger.net>,
> 	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
> 	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
> 	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
> 	Nitin Kuppelur <nitinkuppelur@...il.com>,
> 	Joshua Clayton <stillcompiling@...il.com>,
> 	Vaishali Thakkar <vthakkar1994@...il.com>,
> 	Tapasweni Pathak <tapaswenipathak@...il.com>,
> 	Daniel Baluta <daniel.baluta@...el.com>,
> 	Melike Yurtoglu <aysemelikeyurtoglu@...il.com>,
> 	Max Perepelitsyn <mperepelitsyn@...il.com>,
> 	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
> 	Cristina Opriceana <cristina.opriceana@...il.com>,
> 	Dogukan Ergun <dogukan.ergun@...il.com>,
> 	Julia Lawall <Julia.Lawall@...6.fr>,
> 	Dan Carpenter <dan.carpenter@...cle.com>,
> 	Haneen Mohammed <hamohammed.sa@...il.com>,
> 	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> Cc: devel@...verdev.osuosl.org,
> 	linux-kernel@...r.kernel.org
> Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
> Date: Mon, 27 Jul 2015 21:41:10 -0700
> Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@...il.com>
> X-Mailer: git-send-email 2.4.6
> In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
> References: <cover.1438057939.git.stillcompiling@...il.com>
> In-Reply-To: <cover.1438057939.git.stillcompiling@...il.com>
> References: <cover.1438057939.git.stillcompiling@...il.com>

Something is wrong. The same patch is getting repeated in the same mail
multiple times. I deleted almost 2500 lines after this before sending
this reply. See how your patch is looking like:
http://www.gossamer-threads.com/lists/linux/kernel/2224869

regards
sudip

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/