linux-kernel - Re: [PATCH] soc: versatile: Use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZGF2CYhLUWT1BxNKGR=adAZbN6NrhfyW3yWmBUaVOYRw@mail.gmail.com>
Date:	Tue, 28 Jul 2015 14:05:00 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Vaishali Thakkar <vthakkar1994@...il.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Axel Lin <axel.lin@...ics.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: versatile: Use devm_kzalloc

On Mon, Jul 27, 2015 at 5:23 AM, Vaishali Thakkar
<vthakkar1994@...il.com> wrote:

> This patch introduces the use of devm_kzalloc and does away
> with kfree in the probe function.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Please get this through ARM SoC or tell me if I should handle it.

> Some comments on this patch and driver:
> - Here, after this change there will be a kfree on the failure of
>   the regmap_read too. I am not sure if driver is currently missing
>   it or there is something else happening here. Also, I think there
>   should be soc_device_unregister under the regmap_read.

Likely. There are sloppy errors everywhere.

> - Moreover, get_maintainer.pl is not pointing me towards any particular
>   mailing list or maintainers. So, I am sending this patch to all
>   commiters as there are only three commits for this driver.

This is my code, also my stupid bugs :/

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/