linux-kernel - RE: [PATCH net v2 2/2] r8152: reset device when tx timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 12:31:09 +0000
From:	Hayes Wang <hayeswang@...ltek.com>
To:	Oliver Neukum <oneukum@...e.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	nic_swsd <nic_swsd@...ltek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH net v2 2/2] r8152: reset device when tx timeout

Oliver Neukum [mailto:oneukum@...e.com]
> Sent: Tuesday, July 28, 2015 8:14 PM
[...]
> >  static void rtl8152_tx_timeout(struct net_device *netdev)  {
> >         struct r8152 *tp = netdev_priv(netdev);
> > -       int i;
> >
> >         netif_warn(tp, tx_err, netdev, "Tx timeout\n");
> > -       for (i = 0; i < RTL8152_MAX_TX; i++)
> > -               usb_unlink_urb(tp->tx_info[i].urb);
> > +
> > +       usb_queue_reset_device(tp->intf);
> > +       cancel_delayed_work(&tp->schedule);
> 
> Sorry to bother you again, but this looks wrong.
> You want to cancel first. There is no point in running any work before the reset is
> done. It will undo any progress anyway.

Excuse me. Do you mean I don't need cancel the other work because it wouldn't be
run before the reset is finished?

Best Regards,
Hayes