linux-kernel - Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 13:43:38 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Wim Van Sebroeck <wim@...ana.be>, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jean Delvare <jdelvare@...e.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Matt Fleming <matt.fleming@...el.com>,
	Peter Tyser <ptyser@...-inc.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Aaron Sierra <asierra@...-inc.com>
Subject: Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform
 data

On Tue, 28 Jul, at 12:37:21PM, Lee Jones wrote:
> 
> The driver shouldn't be called that either.
> 
> You are the only one.  What makes iTCO 'special'?

I don't know, I didn't write it. It looks like Wim did ~9 years ago, so
it must have made sense to him at the time.

> > > > +	info = &lpc_chipset_info[priv->chipset];
> > > > +
> > > > +	pdata->iTCO_version = info->iTCO_version;
> > > 
> > > Lowercase please.
> > 
> > Hmm... but then this line will read,
> > 
> > 	pdata->itco_version = info->iTCO_version;
> > 
> > I'm not sure that's an improvement.
> 
> Please consider making all of the variable names conform to the
> coding standards we normally abide by.  You can submit it either as
> patch 1 of this set, or independently.

Right, I figured we were fast approaching this rabit hole.
 
-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/