linux-kernel - Re: [PATCH V2 4/6] perf,tools: save misc sample read value in struct perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150728135512.GD28175@krava.brq.redhat.com>
Date:	Tue, 28 Jul 2015 15:55:12 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	"Liang, Kan" <kan.liang@...el.com>
Cc:	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"acme@...nel.org" <acme@...nel.org>,
	"luto@...nel.org" <luto@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"eranian@...gle.com" <eranian@...gle.com>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"Hunter, Adrian" <adrian.hunter@...el.com>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"namhyung@...nel.org" <namhyung@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 4/6] perf,tools: save misc sample read value in struct
 perf_sample

On Mon, Jul 27, 2015 at 10:24:49PM +0000, Liang, Kan wrote:

SNIP

> > >freq_perf_data,
> > > +					    sample-
> > >read.group.values[nr].value);
> > 
> > I think this should be in upper layer..
> 
> OK, I'll move it to deliver_sample_group.
> 
> > why not do this also within
> > iter_prepare_normal_entry as for the rest of the calculations I suggested
> > in my other email
> 
> Because we cannot get evlist in iter_add/prepare function. We cannot go
> through all group members' value. 
> It's too complex (need to change many interfaces) to pass the evlist to
> iter_add/prepare function

hum, I remember Namhyung added iter->add_entry_cb, but seems it's called
after the entry is added.. how about adding pre-addition callback?

it can reach the report structure with perf_evlist

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/