linux-kernel - Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1507281735430.2343@hadrien>
Date:	Tue, 28 Jul 2015 17:37:16 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Joshua Clayton <stillcompiling@...il.com>
cc:	Larry Finger <Larry.Finger@...inger.net>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Nitin Kuppelur <nitinkuppelur@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates
 to rates

> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 83d4bca..1ded691 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
>  	/* Add the protocol name */
>  	iwe.cmd = SIOCGIWNAME;
>  	if ((r8712_is_cckratesonly_included(pnetwork->network.
> -	     SupportedRates)) == true) {
> +	     rates)) == true) {
>  		if (ht_cap == true)
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
>  		else
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
>  	} else if ((r8712_is_cckrates_included(pnetwork->network.
> -		    SupportedRates)) == true) {
> +		    rates)) == true) {
>  		if (ht_cap == true)
>  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
>  		else

The placement of the line breaks here is partucularly unpleasant.  Perhaps
that could be adjusted now that the field name is shorter.  Theer may be
some other cases in the patch where the line breaks could be adjusted to
improve readability.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/