linux-kernel - Re: [Intel-gfx] [PATCH 2/3] drm/i915: hide errors when probing for a reverse display port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150728161831.GF16528@nuc-i3427.alporthouse.com>
Date:	Tue, 28 Jul 2015 17:18:31 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Daniel Vetter <daniel.vetter@...el.com>,
	intel-gfx@...ts.freedesktop.org, Todd Broch <tbroch@...omium.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: hide errors when probing for a
 reverse display port

On Tue, Jul 28, 2015 at 12:03:28PM -0400, Benjamin Tissoires wrote:
> We check the polarity of the attached dp, so it is normal to fail.
> Do not send errors to the users.

if (probe) DRM_DEBUG else DRM_ERROR is fairly offensive.

It strikes me that you could make each of these functions report the
failure to the caller (have the caller even do so error handling!) and
as part of that have the caller report an error and so demote all of
these to DRM_DEBUG_KMS().

Who knows, actually doing some error handling may make monitor training
more reliable! Or we may even get carried away and report the failure
all the way back to userspace.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/