[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <s5hr3nre9vo.wl-tiwai@suse.de>
Date: Wed, 29 Jul 2015 08:49:31 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm v2] sound: convert to parse_integer()
On Tue, 28 Jul 2015 23:06:15 +0200,
Andrew Morton wrote:
>
> On Tue, 28 Jul 2015 00:03:01 +0300 Alexey Dobriyan <adobriyan@...il.com> wrote:
>
> > Convert away from deprecated simple_strto*() interfaces to
> > parse_integer() and kstrto*().
>
> The patch does a lot more than this! It also adds lots of handling of
> previously-ignored errors.
Yes, please give more description.
> And it thereby introduces possible back-compatibility issues. Someone
> who is doing "echo 42foo > wherever" will now get an error, whereas
> they previously got 42.
Right, many strings don't care about spaces, i.e. it contains trailing
spaces, so the patch seems doing way too strict. I think it's better
to omit the word termination check in each place.
> So hm. Probably a good patch and I'll stick it in -mm for testing, but
> this should go upstream via tiwai, please.
Well, but parse_integer() isn't upstreamed yet, so it has to be after
mm tree, right?
thanks,
Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists