| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1438154956.25925.132.camel@mhfsdcap03>
Date: Wed, 29 Jul 2015 15:29:16 +0800
From: Yong Wu <yong.wu@...iatek.com>
To: Daniel Kurtz <djkurtz@...gle.com>
CC: Joerg Roedel <joro@...tes.org>,
Thierry Reding <treding@...dia.com>,
Mark Rutland <mark.rutland@....com>,
Matthias Brugger <matthias.bgg@...il.com>,
Robin Murphy <robin.murphy@....com>,
Will Deacon <will.deacon@....com>,
Tomasz Figa <tfiga@...gle.com>,
Lucas Stach <l.stach@...gutronix.de>,
Rob Herring <robh+dt@...nel.org>,
Catalin Marinas <catalin.marinas@....com>,
<linux-mediatek@...ts.infradead.org>,
Sasha Hauer <kernel@...gutronix.de>,
srv_heupstream <srv_heupstream@...iatek.com>,
"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"open list:IOMMU DRIVERS" <iommu@...ts.linux-foundation.org>,
Paul Bolle <pebolle@...cali.nl>,
"Arnd Bergmann" <arnd@...db.de>, <mitchelh@...eaurora.org>,
<cloud.chou@...iatek.com>, <frederic.chen@...iatek.com>
Subject: Re: [PATCH v3 6/6] dts: mt8173: Add iommu/smi nodes for mt8173
On Thu, 2015-07-23 at 22:40 +0800, Daniel Kurtz wrote:
> Hi Yong,
>
> On Thu, Jul 16, 2015 at 5:04 PM, Yong Wu <yong.wu@...iatek.com> wrote:
> >
> > This patch add the iommu/larbs nodes for mt8173
>
> To what tree does this apply?
> Please rebase these patches (especially this one) on an Matthias'
> current v4.2-next/for-next.
Hi Daniel,
Sorry for reply so late. I will rebase these patch next time.
And the m4u/smi dsti is based on clocks, So I have to add the
patches of the latest MTK clocks[1] locally, then prepare this iommu
dtsi patch.
[1]:http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001800.html
>
>
> >
> > Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 81 ++++++++++++++++++++++++++++++
> > 1 file changed, 81 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index e81ac1f..7b8e73c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -14,6 +14,7 @@
> > #include <dt-bindings/clock/mt8173-clk.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/memory/mt8173-larb-port.h>
> > #include <dt-bindings/power/mt8173-power.h>
> > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > #include "mt8173-pinfunc.h"
> > @@ -240,6 +241,17 @@
> > reg = <0 0x10200620 0 0x20>;
> > };
> >
> > + iommu: mmsys_iommu@...05000 {
>
> This name should be generic, like this (this comment really applies to
> the binding patch):
>
> iommu: iommu@...05000
Thanks.
>
> > + compatible = "mediatek,mt8173-m4u";
> > + reg = <0 0x10205000 0 0x1000>;
> > + interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&infracfg CLK_INFRA_M4U>;
> > + clock-names = "bclk";
> > + mediatek,larb = <&larb0 &larb1 &larb2
> > + &larb3 &larb4 &larb5>;
>
> Tiny nit... please align the "&".
>
> Otherwise, this one is:
>
> Reviewed-by: Daniel Kurtz <djkurtz@...omium.org>
Thanks very much. I will improve them next version.
Look forward to that line:)
>
> Thanks!
> -Dan
>
> > + #iommu-cells = <2>;
> > + };
> > +
> > apmixedsys: clock-controller@...09000 {
> > compatible = "mediatek,mt8173-apmixedsys";
> > reg = <0 0x10209000 0 0x1000>;
> > @@ -401,29 +413,98 @@
> > #clock-cells = <1>;
> > };
> >
> > + larb0: larb@...21000 {
> > + compatible = "mediatek,mt8173-smi-larb";
> > + reg = <0 0x14021000 0 0x1000>;
> > + mediatek,smi = <&smi_common>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > + clocks = <&mmsys CLK_MM_SMI_LARB0>,
> > + <&mmsys CLK_MM_SMI_LARB0>;
> > + clock-names = "apb", "smi";
> > + };
> > +
> > + smi_common: smi@...22000 {
> > + compatible = "mediatek,mt8173-smi";
> > + reg = <0 0x14022000 0 0x1000>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > + clocks = <&mmsys CLK_MM_SMI_COMMON>,
> > + <&mmsys CLK_MM_SMI_COMMON>;
> > + clock-names = "apb", "smi";
> > + };
> > +
> > + larb4: larb@...27000 {
> > + compatible = "mediatek,mt8173-smi-larb";
> > + reg = <0 0x14027000 0 0x1000>;
> > + mediatek,smi = <&smi_common>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > + clocks = <&mmsys CLK_MM_SMI_LARB4>,
> > + <&mmsys CLK_MM_SMI_LARB4>;
> > + clock-names = "apb", "smi";
> > + };
> > +
> > imgsys: imgsys@...00000 {
> > compatible = "mediatek,mt8173-imgsys", "syscon";
> > reg = <0 0x15000000 0 0x1000>;
> > #clock-cells = <1>;
> > };
> >
> > + larb2: larb@...01000 {
> > + compatible = "mediatek,mt8173-smi-larb";
> > + reg = <0 0x15001000 0 0x1000>;
> > + mediatek,smi = <&smi_common>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_ISP>;
> > + clocks = <&imgsys CLK_IMG_LARB2_SMI>,
> > + <&imgsys CLK_IMG_LARB2_SMI>;
> > + clock-names = "apb", "smi";
> > + };
> > +
> > vdecsys: vdecsys@...00000 {
> > compatible = "mediatek,mt8173-vdecsys", "syscon";
> > reg = <0 0x16000000 0 0x1000>;
> > #clock-cells = <1>;
> > };
> >
> > + larb1: larb@...10000 {
> > + compatible = "mediatek,mt8173-smi-larb";
> > + reg = <0 0x16010000 0 0x1000>;
> > + mediatek,smi = <&smi_common>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VDEC>;
> > + clocks = <&vdecsys CLK_VDEC_CKEN>,
> > + <&vdecsys CLK_VDEC_LARB_CKEN>;
> > + clock-names = "apb", "smi";
> > + };
> > +
> > vencsys: vencsys@...00000 {
> > compatible = "mediatek,mt8173-vencsys", "syscon";
> > reg = <0 0x18000000 0 0x1000>;
> > #clock-cells = <1>;
> > };
> >
> > + larb3: larb@...01000 {
> > + compatible = "mediatek,mt8173-smi-larb";
> > + reg = <0 0x18001000 0 0x1000>;
> > + mediatek,smi = <&smi_common>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
> > + clocks = <&vencsys CLK_VENC_CKE1>,
> > + <&vencsys CLK_VENC_CKE0>;
> > + clock-names = "apb", "smi";
> > + };
> > +
> > vencltsys: vencltsys@...00000 {
> > compatible = "mediatek,mt8173-vencltsys", "syscon";
> > reg = <0 0x19000000 0 0x1000>;
> > #clock-cells = <1>;
> > };
> > +
> > + larb5: larb@...01000 {
> > + compatible = "mediatek,mt8173-smi-larb";
> > + reg = <0 0x19001000 0 0x1000>;
> > + mediatek,smi = <&smi_common>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
> > + clocks = <&vencltsys CLK_VENCLT_CKE1>,
> > + <&vencltsys CLK_VENCLT_CKE0>;
> > + clock-names = "apb", "smi";
> > + };
> > };
> > };
> >
> > --
> > 1.7.9.5
> >
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists