linux-kernel - Bug: shared usb dt document is incorrect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B82716.1060008@sonymobile.com>
Date:	Tue, 28 Jul 2015 18:06:30 -0700
From:	Tim Bird <tim.bird@...ymobile.com>
To:	Rob Herring <robherring2@...il.com>,
	<antoine.tenart@...e-electrons.com>
CC:	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<Peter.Chen@...escale.com>, <linux-usb@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bjorn Andersson <Bjorn.Andersson@...ymobile.com>
Subject: Bug:  shared usb dt document is incorrect

Antoine and Rob,

I was just doing some testing with USB on a Qualcomm SoC.

I followed the instructions in the binding document:
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt

which has a compatible for "qcom,ci-hdrc", and is, in general,
for chipidea-based USB controllers.

It says in the document that the property usb-phy is deprecated, and to
use phys and phy-names instead.  However, the Qualcomm
driver for this still uses usb-phy.  That driver is in:
drivers/usb/chipidea/ci_hdrc_msm.c

I'm guessing I should update the Qualcomm driver to use
phys and phy-names, but wanted to check with you-all to
verify that this is the preferred method of getting 
phys by phandle now.  It's either change the driver
or make an exception in the binding document, I believe.

I presume I should be changing devm_usb_get_phy_by_phandle()
to of_phy_get(), but let me know if there's more to it than that.

In case I change the driver, do I then update the binding doc
to remove the information about the deprecated property, or not?

Please advise.
 -- Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/