linux-kernel - Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1507291230590.3825@nanos>
Date:	Wed, 29 Jul 2015 12:32:59 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Taichi Kageyama <t-kageyama@...jp.nec.com>
cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"peter@...leysoftware.com" <peter@...leysoftware.com>,
	"jiang.liu@...ux.intel.com" <jiang.liu@...ux.intel.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"prarit@...hat.com" <prarit@...hat.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid
 irq=0 for console

On Wed, 29 Jul 2015, Taichi Kageyama wrote:
> - Keep interrupt disabled on the CPU which is used to detect 
>   an interrupt during the timeout of autoconfig_irq().
>      + Kick printk() on the CPU which detects interrupt 
>        from a console serial port.

This is wrong to begin with. How is that supposed to work on an UP
machine? Not at all.

So no, fix the code which has interrupts disabled accross autoprobing
and do not try to apply bandaids somewhere else.

Thanks,

	tglx




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/