linux-kernel - Re: [PATCH RFC V6 6/6] perf,tests: Add tests to callgraph and time parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150729115314.GE9606@krava.brq.redhat.com>
Date:	Wed, 29 Jul 2015 13:53:14 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Kan Liang <kan.liang@...el.com>
Cc:	acme@...nel.org, jolsa@...nel.org, namhyung@...nel.org,
	ak@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC V6 6/6] perf,tests: Add tests to callgraph and time
 parse

On Mon, Jul 27, 2015 at 08:21:39AM -0400, Kan Liang wrote:
> From: Kan Liang <kan.liang@...el.com>
> 
> Add tests in tests/parse-events.c to check callgraph and time option
> 
> Signed-off-by: Kan Liang <kan.liang@...el.com>
> ---
>  tools/perf/tests/parse-events.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> index f65bb89..fa733d5 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -479,6 +479,29 @@ static int test__checkevent_pmu_name(struct perf_evlist *evlist)
>  	return 0;
>  }
>  
> +static int test__checkevent_pmu_partial_time_callgraph(struct perf_evlist *evlist)
> +{
> +	struct perf_evsel *evsel = perf_evlist__first(evlist);
> +
> +	/* cpu/config=1,callgraph=fp,time,period=100000/ */
> +	TEST_ASSERT_VAL("wrong number of entries", 2 == evlist->nr_entries);
> +	TEST_ASSERT_VAL("wrong type", PERF_TYPE_RAW == evsel->attr.type);
> +	TEST_ASSERT_VAL("wrong config",  1 == evsel->attr.config);
> +	TEST_ASSERT_VAL("wrong period",  100000 == evsel->attr.sample_period);
> +	TEST_ASSERT_VAL("wrong callgraph",  PERF_SAMPLE_CALLCHAIN & evsel->attr.sample_type);
> +	TEST_ASSERT_VAL("wrong time",  PERF_SAMPLE_TIME & evsel->attr.sample_type);
> +
> +	/* cpu/config=2,callgraph=no,time=0,period=2000/ */
> +	evsel = perf_evsel__next(evsel);
> +	TEST_ASSERT_VAL("wrong type", PERF_TYPE_RAW == evsel->attr.type);
> +	TEST_ASSERT_VAL("wrong config",  2 == evsel->attr.config);
> +	TEST_ASSERT_VAL("wrong period",  2000 == evsel->attr.sample_period);
> +	TEST_ASSERT_VAL("wrong callgraph",  !(PERF_SAMPLE_CALLCHAIN & evsel->attr.sample_type));
> +	TEST_ASSERT_VAL("wrong time",  !(PERF_SAMPLE_TIME & evsel->attr.sample_type));

hum, this cannot pass right? we dont call perf_evsel__config in this test..

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/