linux-kernel - Re: [linux-next:master 2506/4558] fs/orangefs/pvfs2-sysfs.c:753:5: sparse: symbol 'sysfs_service_op_show' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOg9mSST1FbTLuK5NBviFT0tF6-iMydRBo3TohpNigW4BaRr7g@mail.gmail.com>
Date:	Wed, 29 Jul 2015 10:53:50 -0400
From:	Mike Marshall <hubcap@...ibond.com>
To:	linux-kernel@...r.kernel.org
Cc:	Mike Marshall <hubcap@...ibond.com>, linux-fsdevel@...r.kernel.org
Subject: Re: [linux-next:master 2506/4558] fs/orangefs/pvfs2-sysfs.c:753:5:
 sparse: symbol 'sysfs_service_op_show' was not declared. Should it be static?

I have fixed most of the sparse complaints and posted the patch.

I use "git send-email" and have tried to tie the addendums to the
original patch set with the message-id in "In-Reply-To:" and "References:"
message headers... if "fold the followup patch" means something different,
please let me know <g>...

-Mike

On Mon, Jul 27, 2015 at 6:33 AM, kbuild test robot
<fengguang.wu@...el.com> wrote:
> Hi Mike,
>
> First bad commit (maybe != root cause):
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   83a5f7f22cae24ea602152424bc9026fdc689ae9
> commit: 2b651e05251d9f8149c998f6d2ca341ecb05a5aa [2506/4558] Orangefs: kernel client part 7
> reproduce:
>   # apt-get install sparse
>   git checkout 2b651e05251d9f8149c998f6d2ca341ecb05a5aa
>   make ARCH=x86_64 allmodconfig
>   make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> fs/orangefs/pvfs2-sysfs.c:753:5: sparse: symbol 'sysfs_service_op_show' was not declared. Should it be static?
>>> fs/orangefs/pvfs2-sysfs.c:1026:5: sparse: symbol 'sysfs_service_op_store' was not declared. Should it be static?
> --
>>> fs/orangefs/pvfs2-mod.c:50:7: sparse: symbol 'DEBUG_LINE' was not declared. Should it be static?
> --
>>> fs/orangefs/super.c:272:25: sparse: symbol 'pvfs2_s_ops' was not declared. Should it be static?
>>> fs/orangefs/super.c:282:15: sparse: symbol 'pvfs2_fh_to_dentry' was not declared. Should it be static?
>>> fs/orangefs/super.c:302:5: sparse: symbol 'pvfs2_encode_fh' was not declared. Should it be static?
>>> fs/orangefs/super.c:350:5: sparse: symbol 'pvfs2_fill_sb' was not declared. Should it be static?
> --
>>> fs/orangefs/devpvfs2-req.c:867:13: sparse: incorrect type in assignment (different address spaces)
>    fs/orangefs/devpvfs2-req.c:867:13:    expected void *__pu_val
>    fs/orangefs/devpvfs2-req.c:867:13:    got void [noderef] <asn:1>*
> --
>>> fs/orangefs/pvfs2-bufmap.c:31:3: sparse: symbol '__pvfs2_bufmap' was not declared. Should it be static?
>>> fs/orangefs/pvfs2-bufmap.c:718:36: sparse: incorrect type in assignment (different address spaces)
>    fs/orangefs/pvfs2-bufmap.c:718:36:    expected void *from_kaddr
>    fs/orangefs/pvfs2-bufmap.c:718:36:    got void [noderef] <asn:1>*iov_base
>    fs/orangefs/pvfs2-bufmap.c:724:36: sparse: incorrect type in assignment (different address spaces)
>    fs/orangefs/pvfs2-bufmap.c:724:36:    expected void *from_kaddr
>    fs/orangefs/pvfs2-bufmap.c:724:36:    got void [noderef] <asn:1>*iov_base
>    fs/orangefs/pvfs2-bufmap.c:730:36: sparse: incorrect type in assignment (different address spaces)
>    fs/orangefs/pvfs2-bufmap.c:730:36:    expected void *from_kaddr
>    fs/orangefs/pvfs2-bufmap.c:730:36:    got void [noderef] <asn:1>*iov_base
>>> fs/orangefs/pvfs2-bufmap.c:940:34: sparse: incorrect type in assignment (different address spaces)
>    fs/orangefs/pvfs2-bufmap.c:940:34:    expected void *to_kaddr
>    fs/orangefs/pvfs2-bufmap.c:940:34:    got void [noderef] <asn:1>*iov_base
>    fs/orangefs/pvfs2-bufmap.c:946:34: sparse: incorrect type in assignment (different address spaces)
>    fs/orangefs/pvfs2-bufmap.c:946:34:    expected void *to_kaddr
>    fs/orangefs/pvfs2-bufmap.c:946:34:    got void [noderef] <asn:1>*iov_base
>    fs/orangefs/pvfs2-bufmap.c:952:34: sparse: incorrect type in assignment (different address spaces)
>    fs/orangefs/pvfs2-bufmap.c:952:34:    expected void *to_kaddr
>    fs/orangefs/pvfs2-bufmap.c:952:34:    got void [noderef] <asn:1>*iov_base
> --
>>> fs/orangefs/pvfs2-debugfs.c:73:1: sparse: symbol 'orangefs_debug_lock' was not declared. Should it be static?
> --
>>> fs/orangefs/waitqueue.c:256:6: sparse: context imbalance in 'pvfs2_clean_up_interrupted_operation' - different lock contexts for basic block
>
> Please review and possibly fold the followup patch.
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/