linux-kernel - Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150729154322.GI575@kernel.org>
Date:	Wed, 29 Jul 2015 12:43:22 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	kan.liang@...el.com, a.p.zijlstra@...llo.nl, luto@...nel.org,
	mingo@...hat.com, eranian@...gle.com, ak@...ux.intel.com,
	mark.rutland@....com, adrian.hunter@...el.com, jolsa@...nel.org,
	namhyung@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY%
 in report -D

Em Wed, Jul 29, 2015 at 02:53:29PM +0200, Jiri Olsa escreveu:
> On Tue, Jul 28, 2015 at 07:29:33AM -0400, kan.liang@...el.com wrote:
> 
> SNIP
> 
> >  
> > -static int machines__deliver_event(struct machines *machines,
> > +static int machines__deliver_event(struct perf_session *session,
> >  				   struct perf_evlist *evlist,
> >  				   union perf_event *event,
> >  				   struct perf_sample *sample,
> >  				   struct perf_tool *tool, u64 file_offset)
> >  {
> > +	struct machines *machines = &session->machines;
> >  	struct perf_evsel *evsel;
> >  	struct machine *machine;
> >  
> > @@ -1053,11 +1079,12 @@ static int machines__deliver_event(struct machines *machines,
> >  
> >  	switch (event->header.type) {
> >  	case PERF_RECORD_SAMPLE:
> > -		dump_sample(evsel, event, sample);
> >  		if (evsel == NULL) {
> >  			++evlist->stats.nr_unknown_id;
> >  			return 0;
> >  		}
> > +		dump_sample(session, evlist, evsel, event, sample);
> 
> same here, you could pass only session all the way through

I'll take a look at how interesting it would be to have a evsel->evlist,
that if NULL means the evsel is freestanding, but when it is linked to
an evlist, then it will be there. This way we wouldn't have to pass
(evlist, evsel) when the main purpose of a function is about an evsel
but we need information that is logically associated to all evsels in a
list, i.e. that is in evsel->evlist.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/