linux-kernel - Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55B8FC7E.50900@broadcom.com>
Date:	Wed, 29 Jul 2015 09:17:02 -0700
From:	Ray Jui <rjui@...adcom.com>
To:	Arnd Bergmann <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
CC:	Olof Johansson <olof@...om.net>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Hauke Mehrtens <hauke@...ke-m.de>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <arm@...nel.org>,
	<bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig



On 7/29/2015 7:30 AM, Arnd Bergmann wrote:
> On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
>>  config PCIE_IPROC_BCMA
>>         bool "Broadcom iProc PCIe BCMA bus driver"
>> -       depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>> +       depends on ARCH_BCM_IPROC && ARM
>>         select PCIE_IPROC
>>         select BCMA
>>         select PCI_DOMAINS
>>
> 
> How about this:
> 
> 	depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
> 
> That would leave the compile test present for non-iproc
> ARM platforms while preventing ARM64 and MIPS builds with
> ARCH_BCM_IPROC set.
> 
> 	Arnd
> 

That is indeed better. Broader compile test coverage is always good.
I'll submit another patch with the above suggested change.

Thanks,

Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/