linux-kernel - Re: [PATCH] virtio_mmio: add ACPI probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150729210114-mutt-send-email-mst@redhat.com>
Date:	Wed, 29 Jul 2015 21:03:14 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Peter Maydell <peter.maydell@...aro.org>
Cc:	G Gregory <graeme.gregory@...aro.org>,
	"virtualization@...ts.linux-foundation.org" 
	<virtualization@...ts.linux-foundation.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Shannon Zhao <shannon.zhao@...aro.org>,
	Alex Bennée <alex.bennee@...aro.org>
Subject: Re: [PATCH] virtio_mmio: add ACPI probing

On Wed, Jul 29, 2015 at 06:52:29PM +0100, Peter Maydell wrote:
> On 28 July 2015 at 11:33, G Gregory <graeme.gregory@...aro.org> wrote:
> > We assigned LNRO in ASWG to avoid collisions with our prototypes/real
> > platforms so it makes sense to me to switch to QEMUXXXX.
> 
> So just to check, if we switch virtio-mmio from an LNRO0005 ID
> to a QEMUxxxx ID we aren't going to break any existing widely
> shipped or deployed code, right?
> 
> If we can change the ID without breaking anything significant
> then I think the QEMU ID makes more sense; but it doesn't
> really gain us much beyond tidiness.
> 
> PS: https://www.kernel.org/doc/Documentation/arm64/arm-acpi.txt
> uses virtio-mmio and LNRO0005 as its code example, so if
> we change this then it might be nice to update the docs
> as a followup.
> 
> thanks
> -- PMM

So this is the proposed patch. I agree it's merely about tidyness.
Pls ack or nack - we need to decide before 2.4 is out.

-->

arm: change vendor ID for virtio-mmio

Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

---

diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index f365140..d10bd69 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -145,7 +145,7 @@ static void acpi_dsdt_add_virtio(Aml *scope,
 
     for (i = 0; i < num; i++) {
         Aml *dev = aml_device("VR%02u", i);
-        aml_append(dev, aml_name_decl("_HID", aml_string("LNRO0005")));
+        aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0005")));
         aml_append(dev, aml_name_decl("_UID", aml_int(i)));
 
         Aml *crs = aml_resource_template();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/