linux-kernel - Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gEfxd7EhONYGq8xEt8pOCVRE-F=YeJULfLB-=VZuE55A@mail.gmail.com>
Date:	Wed, 29 Jul 2015 21:57:34 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"Moore, Robert" <robert.moore@...el.com>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"Zheng, Lv" <lv.zheng@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...ica.org" <devel@...ica.org>
Subject: Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul()

Hi Guenter,

On Wed, Jul 29, 2015 at 8:38 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> On 07/29/2015 10:51 AM, Moore, Robert wrote:
>>
>>
>>
>>> -----Original Message-----
>>> From: Guenter Roeck [mailto:linux@...ck-us.net]
>>> Sent: Monday, July 27, 2015 5:32 PM
>>> To: rjw@...ysocki.net
>>> Cc: lenb@...nel.org; Moore, Robert; Zheng, Lv;
>>> linux-acpi@...r.kernel.org;
>>> linux-kernel@...r.kernel.org; devel@...ica.org; Guenter Roeck
>>> Subject: [PATCH v2] acpi: Use kstrtoul() instead of
>>> strtoul()/simple_strtoul()
>>>
>>> simple_strtoul() is deprecated; replace with kstrtoul() and kstrtouint().
>>
>>
>> The ACPICA code is os-independent and cannot use these functions (at least
>> not directly).
>>
>>
> Odd argument, given that kstrtoul() is used already in the acpi code.

Boib is right, the change in sysfs.c is OK, but the one in evgpeinit.c
isn't (this code is automatically generated from the upstream ACPICA
source and manual updates of it are painful).

You might provide a strtoul() wrapper around kstrtoul() instead of its
definition in acpi/platform/aclinux.h, though.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/