linux-kernel - Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfSe-sQjPHQQ7-jh-Xq6nR3O0gtP3AM4m=gGJjUE26rsbQDMQ@mail.gmail.com>
Date:	Thu, 30 Jul 2015 11:38:45 +0800
From:	Chunyan Zhang <zhang.lyra@...il.com>
To:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	peter.lachner@...el.com, norbert.schulz@...el.com,
	keven.boell@...el.com, yann.fouassier@...el.com,
	laurent.fert@...el.com,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	Chunyan Zhang <zhang.chunyan@...aro.org>
Subject: Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System
 Trace Module devices

On Wed, Jul 29, 2015 at 9:46 PM, Alexander Shishkin
<alexander.shishkin@...ux.intel.com> wrote:
> Mark Brown <broonie@...nel.org> writes:
>
>> On Wed, Jul 29, 2015 at 04:25:10PM +0300, Alexander Shishkin wrote:
>>
>>> There has to be a way to defer stm_probe(), although a quick look at
>>> amba code suggests it's not implemented.
>>
>> What makes you say this?  Probe deferral is implemented in the driver
>> core rather than individual buses, the buses don't need to know anything
>> about it.
>
> I stand corrected, it indeed is.
>
> So returning EPROBE_DEFER from stm_probe() should Just Work (provided
> stm_probe() handles its error paths correctly).

If let stm_probe() implement probe deferral, it has to have a global
variable for the later calling of "stm_register_device", because the
first parameter of "stm_register_device" is " struct device * " which
comes from amba_probe(), after finished amba_probe(), we may not get
this structure by other means.

This was a similar policy that we both thought was not good :)

>
> Regards,
> --
> Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/