linux-kernel - Re: [PATCH 4573/4573] Staging: rtl8188eu: fixed newlines after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1438234716.2677.8.camel@perches.com>
Date:	Wed, 29 Jul 2015 22:38:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dave Perez <dave@...eperez.com>
Cc:	gregkh@...uxfoundation.org, tapaswenipathak@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4573/4573] Staging: rtl8188eu: fixed newlines after
 declarations

On Wed, 2015-07-29 at 21:34 -0400, Dave Perez wrote:
> This is a patch to the rtw_debug.c file that fixes styling errors relating to new lines after variable declarations. 
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c b/drivers/staging/rtl8188eu/core/rtw_debug.c
[]
> @@ -219,6 +219,7 @@ int proc_get_ht_option(char *page, char **start,
>  	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
>  
>  	int len = 0;
> +
>  	len += snprintf(page + len, count - len, "ht_option=%d\n", pmlmepriv->htpriv.ht_option);
>  	*eof = 1;
>  	return len;

the blank line before "int len = 0" could also be removed.

The routine _could_ be rewritten more simply as:

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
	int len = snprintf(page, count, "ht_option=%d\n",
			   pmlmepriv->htpriv.htoption);

	*eof = 1;

	return len;
}

but there are a bunch of other routines that use this form
so it's probably fine as-is.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/