linux-kernel - Re: [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jul 2015 09:19:51 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Steve Rutherford <srutherford@...gle.com>
Cc:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	alex.williamson@...hat.com, yang.z.zhang@...el.com,
	srutherford@...el.com
Subject: Re: [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU



On 30/07/2015 05:55, Steve Rutherford wrote:
> >  static void vcpu_scan_ioapic(struct kvm_vcpu *vcpu)
> >  {
> > -	u64 eoi_exit_bitmap[4];
> > -
> >  	if (!kvm_apic_hw_enabled(vcpu->arch.apic))
> >  		return;
> >  
> > -	memset(eoi_exit_bitmap, 0, 32);
> > +	memset(vcpu->arch.eoi_exit_bitmap, 0, 256 / 8);
> >  
> > -	kvm_ioapic_scan_entry(vcpu, eoi_exit_bitmap);
> > -	kvm_x86_ops->load_eoi_exitmap(vcpu, eoi_exit_bitmap);
> > +	kvm_ioapic_scan_entry(vcpu, vcpu->arch.eoi_exit_bitmap);
> Nit: Does scan entry still need to carry around the pointer to the bitmap?

IIRC I was copying what you did in your patch, but I also think it's
better this way.  The IOAPIC has no business in the vcpu structure's
fields; it only needs it in order to pass vcpu to kvm_apic_match_dest.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/