[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150730094611.GC488@griffinp-ThinkPad-X1-Carbon-2nd>
Date: Thu, 30 Jul 2015 10:46:11 +0100
From: Peter Griffin <peter.griffin@...aro.org>
To: Mauro Carvalho Chehab <mchehab@....samsung.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
srinivas.kandagatla@...il.com, maxime.coquelin@...com,
patrice.chotard@...com, lee.jones@...aro.org,
hugues.fruchet@...com, linux-media@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X
tuner.
Hi Mauro,
On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:
> Em Wed, 24 Jun 2015 16:11:00 +0100
> Peter Griffin <peter.griffin@...aro.org> escreveu:
>
> > This is used in conjunction with the STV0367 demodulator on
> > the STV0367-NIM-V1.0 NIM card which can be used with the STi
> > STB SoC's.
> >
> > This tuner has a fifth register, so some changes have been made
> > to accommodate this.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> > ---
> > drivers/media/dvb-frontends/dvb-pll.c | 74 +++++++++++++++++++++++++++++------
> > drivers/media/dvb-frontends/dvb-pll.h | 1 +
> > 2 files changed, 64 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/media/dvb-frontends/dvb-pll.c b/drivers/media/dvb-frontends/dvb-pll.c
> > index 6d8fe88..f7381c7 100644
> > --- a/drivers/media/dvb-frontends/dvb-pll.c
> > +++ b/drivers/media/dvb-frontends/dvb-pll.c
> > @@ -141,6 +141,35 @@ static struct dvb_pll_desc dvb_pll_thomson_dtt7520x = {
> > },
> > };
> >
> > +static void thomson_dtt7546x_bw(struct dvb_frontend *fe, u8 *buf)
> > +{
> > + /* set CB2 reg - set ATC, XTO */
> > + buf[4] = 0xc3;
> > +}
> > +
> > +static struct dvb_pll_desc dvb_pll_thomson_dtt7546x = {
> > + .name = "Thomson dtt7546x",
> > + .min = 44250000,
> > + .max = 863250000,
> > + .set = thomson_dtt7546x_bw,
> > + .iffreq= 36166667,
>
> Whitespace is missing. Please check the patchs with scripts/checkpatch.pl.
Will fix in V2.
regards,
Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists