linux-kernel - Re: [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150730114415.GP30895@pengutronix.de>
Date:	Thu, 30 Jul 2015 13:44:15 +0200
From:	Markus Pargmann <mpa@...gutronix.de>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Vlad Dogaru <vlad.dogaru@...el.com>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c
 access

On Thu, Jul 30, 2015 at 12:49:28PM +0200, Paul Bolle wrote:
> On wo, 2015-07-29 at 20:37 +0200, Markus Pargmann wrote:
> > On Wed, Jul 29, 2015 at 03:46:04PM +0200, Markus Pargmann wrote:
> > > +struct regmap_config bmg160_regmap_i2c_conf = {
> > 
> > This should probably be static const ...
> 
> Likewise for "bmg160_regmap_conf", which you add in 7/7, right?

Yes, thanks.

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)