linux-kernel - Re: [PATCH] sched: Avoid sched domain rebuilding when hotplugging an isolate cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150730115139.GG25159@twins.programming.kicks-ass.net>
Date:	Thu, 30 Jul 2015 13:51:39 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	pang.xunlei@....com.cn
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Xunlei Pang <pang.xunlei@...aro.org>
Subject: Re: [PATCH] sched: Avoid sched domain rebuilding when hotplugging an
 isolate cpu

On Thu, Jul 30, 2015 at 06:54:47PM +0800, pang.xunlei@....com.cn wrote:
> Hi Peter,
> 
> Peter Zijlstra <peterz@...radead.org> wrote 2015-07-30 PM 06:30:37:
> > Re: [PATCH] sched: Avoid sched domain rebuilding when hotplugging an
> > isolate cpu
> > 
> > On Fri, Jul 17, 2015 at 04:03:45PM +0800, Xunlei Pang wrote:
> > > From: Xunlei Pang <pang.xunlei@...aro.org>
> > > 
> > > The sched domain is always rebuilt when hotplugging an isolate cpu,
> > > as we can see in partition_sched_domains() with the NULL doms_new,
> > > current sched domain is destroyed, then rebuilt. Worse still, the
> > > rebuilding will reset all the parameters of the sched_domain. This
> > > makes no sense and contradicts the isloate concept.
> > 
> > What parameters? isolcpus should have fairly trivial domains to begin
> > with.
> 
> I mean the parameters under 
> /proc/sys/kernel/sched_domain/cpu<m>/domain<n>,
> they will be reset to the default value once sched domain is rebuilt, if 
> users have tuned them before, it's very annoying.
> 
> So we should avoid the rebuilding if can, like the case in this patch.

No, those are _DEBUG_ knobs, they're not guaranteed to have any
persistence what so ever.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/