linux-kernel - Re: [PATCH v2] kthread: Export kthread functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150730120223.GA27430@hmsreliant.think-freely.org>
Date:	Thu, 30 Jul 2015 08:02:24 -0400
From:	Neil Horman <nhorman@...hat.com>
To:	yalin wang <yalin.wang2010@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Kershner <david.kershner@...sys.com>, tj@...nel.org,
	laijs@...fujitsu.com, nacc@...ux.vnet.ibm.com, mingo@...hat.com,
	linux-kernel@...r.kernel.org, jes.sorensen@...hat.com,
	sparmaintainer@...sys.com
Subject: Re: [PATCH v2] kthread: Export kthread functions

On Thu, Jul 30, 2015 at 11:48:17AM +0800, yalin wang wrote:
> 
> > On Jul 29, 2015, at 18:34, Thomas Gleixner <tglx@...utronix.de> wrote:
> > 
> > On Tue, 28 Jul 2015, Andrew Morton wrote:
> > 
> >> On Tue, 28 Jul 2015 11:59:01 -0400 David Kershner <david.kershner@...sys.com> wrote:
> >> 
> >>> The s-Par visornic driver, currently in staging, processes a queue
> >>> being serviced by the an s-Par service partition. We can get a message
> >>> that something has happened with the Service Partition, when that
> >>> happens, we must not access the channel until we get a message that the
> >>> service partition is back again.
> >>> 
> >>> The visornic driver has a thread for processing the channel, when we
> >>> get the message, we need to be able to park the thread and then resume
> >>> it when the problem clears.
> >>> 
> >>> We can do this with kthread_park and unpark but they are not exported
> >>> from the kernel, this patch exports the needed functions.
> >>> 
> >>> Signed-off-by: David Kershner <david.kershner@...sys.com>
> >> 
> >> Please accumulate the acked-by's and reviewed-by's in the changelog as
> >> they are received.   I presently have
> >> 
> >> Acked-by: Ingo Molnar <mingo@...nel.org>
> >> Acked-by: Neil Horman <nhorman@...driver.com>
> >> Cc: Thomas Gleixner <tglx@...utronix.de>
> >> Cc: Richard Weinberger <richard.weinberger@...il.com>
> >> Cc: Tejun Heo <tj@...nel.org>
> >> 
> >> 
> >> I'll scoot this into mainline probably this week to make life simpler
> >> for the various trees.
> > 
> i am curious why not make some tiny functions to be inline ?
> so that don’t need EXPORT_SYMOBLS , shrink the kernel size.
> Thanks

Because exporting symbols isn't a big deal, and the compiler can decide when its
best to inline these functions.  As it is, they aren't that small, if you expand
all their internals

Neil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/