linux-kernel - Re: [PATCH] x86/mm, efi: Check for valid image type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150730130235.GF2725@codeblueprint.co.uk>
Date:	Thu, 30 Jul 2015 14:02:35 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Dave Young <dyoung@...hat.com>
Cc:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	josh@...htriplett.org, Matt Fleming <matt.fleming@...el.com>,
	x86@...nel.org, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mm, efi: Check for valid image type

On Wed, 29 Jul, at 05:37:52PM, Dave Young wrote:
> 
> Not sure if BGRT is useful in kexec kernel, it seems not worth to copy
> it between kernels.
> 
> IMO just return in case if (efi_setup) is true make sense.

Yes, I think it makes sense to skip touching the BGRT on kexec boot.

As a side note, we should really look at using one of the efi_enabled()
bits to signal when we're booting a kexec'd kernel because it is not at
all obvious that 'efi_setup != 0' means we're in kexec kernel.

But that wants to be a separate patch from this issue.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/