linux-kernel - Re: [PATCH 4/4] perf, tools, stat: Implement CSV metrics output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150730140848.GS9606@krava.brq.redhat.com>
Date:	Thu, 30 Jul 2015 16:08:48 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...nel.org, jolsa@...nel.org, eranian@...gle.com,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 4/4] perf, tools, stat: Implement CSV metrics output

On Wed, Jul 29, 2015 at 05:21:40PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> Now support CSV output for metrics. With the new output callbacks
> this is relatively straight forward by creating new callbacks.
> 
> The new line callback needs to know the number of fields to skip them
> correctly
> 
> To avoid reordering the existing CSV fields, I had to move
> the noise printing into the lower level print metrics call back,
> so that noise can be printed before metrics.
> 
> This actually cleans up the callers because it avoids a lot
> of duplicated code.

nice, please separate the cleanup from the actual addition
of the metrics CSV fields

could you please also start some documentation in perf stat man?
I dont think we have anything yet.. and it's getting bigger ;-)

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/