linux-kernel - Re: [PATCH v1 1/7] ARM: dts: ifc6410: Add pwrseq support for WLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150730001230.GD6519@usrtlx11787.corpusers.net>
Date:	Wed, 29 Jul 2015 17:12:30 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
CC:	<agross@...eaurora.org>, <linux-arm-msm@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	<devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/7] ARM: dts: ifc6410: Add pwrseq support for WLAN

On Tue 28 Jul 05:53 PDT 2015, Srinivas Kandagatla wrote:

> This patch adds pwrseq for WLAN which resets the WLAN just before the
> SDIO bus is up.
> 

Does this mean that we have the !power-of-2 patch in mmc on the way?

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> index 88d6655..df560cf 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> @@ -1,5 +1,6 @@
>  #include "qcom-apq8064-v2.0.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>  
>  / {
>  	model = "Qualcomm APQ8064/IFC6410";
> @@ -206,6 +207,28 @@
>  			status = "okay";
>  		};
>  
> +		qcom,ssbi@...000 {
> +			pmicintc: pmic@0 {
> +				pm8921_gpio: gpio@150 {

These should already be labeled in the apq8064 dtsi (or in a
qcom-pm8921.dtsi).

> +					pinctrl-names = "default";
> +					pinctrl-0 = <&wlan_default_gpios>;

Please move these to the pwrseq node, as that's the consumer of this.

> +					wlan_default_gpios: wlan-gpios {
> +						pios {
> +							pins = "gpio43";
> +							function = "normal";
> +							bias-disable;
> +							power-source = <PM8921_GPIO_S4>;
> +						};
> +					};
> +				};
> +			};
> +		};

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/