linux-kernel - Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r3npbeyo.fsf@rasmusvillemoes.dk>
Date:	Thu, 30 Jul 2015 21:52:31 +0200
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Kees Cook <keescook@...omium.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Mathias Krause <minipli@...glemail.com>,
	James Bottomley <JBottomley@...n.com>
Subject: Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem

On Fri, Jul 24 2015, Kees Cook <keescook@...omium.org> wrote:

> The esc argument is used to reduce which characters will be escaped.
> For example, using " " with ESCAPE_SPACE will not produce any escaped
> spaces.
>

Yeah, I've been confused by this more than once - the old description
and the parameter name suggest that the esc string contains additional
characters to escape, not the other way around.

Could we also rename the parameter 'only' or something like that? In any
case,

Acked-by: Rasmus Villemoes <linux@...musvillemoes.dk>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/