[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150731071358.GA25228@gondor.apana.org.au>
Date: Fri, 31 Jul 2015 15:13:58 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Rameshwar Prasad Sahu <rsahu@....com>
Cc: vinod.koul@...el.com, dan.j.williams@...el.com,
davem@...emloft.net, linux-crypto@...r.kernel.org,
dmaengine@...r.kernel.org, arnd@...db.de,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, jcm@...hat.com,
patches@....com
Subject: Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w
accelerator driver
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
>
> + .cra_name = "xgene(crc32c)",
> + .cra_driver_name = "crc32c-xgene",
This looks wrong. If you're implementing crc32c then cra_name
should be just crc32c, i.e., the name of the algorithm that you
are providing.
> +MODULE_DESCRIPTION("APM X-Gene SoC CRC32C HW accelerator driver");
> +MODULE_AUTHOR("Rameshwar Prasad Sahu <rsahu@....com>");
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION("1.0");
You should add a MODULE_ALIAS_CRYPTO too.
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists