[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150731.002204.2044640569422262574.davem@davemloft.net>
Date: Fri, 31 Jul 2015 00:22:04 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: nathan.sullivan@...com
Cc: f.fainelli@...il.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume
From: Nathan Sullivan <nathan.sullivan@...com>
Date: Thu, 30 Jul 2015 18:09:05 -0500
> On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote:
>> From: Nathan Sullivan <nathan.sullivan@...com>
>> Date: Thu, 30 Jul 2015 10:15:48 -0500
>>
>> > Changes for V2: Actually make sure it compiles this time.
>>
>> If V1 didn't compile, even for you, then I have a big problem.
>>
>> And that problem is that you didn't test this change at all.
>
> Sorry about that, I have tested it against 3.14, which is why I had
> the older interrupt function in v1. On HEAD, the phy no longer
> suspends when ethernet goes down on our hardware - I'm still working
> on figuring out why. I'm also surprised no one noticed this behavior
> before I did, but if the phy never goes into suspend you wouldn't.
I think you should sort out the PHY suspending issue before we move
forward with this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists