linux-kernel - Re: [PATCH 06/13] staging/lustre: Drop SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150731230053.GA22744@kroah.com>
Date:	Fri, 31 Jul 2015 16:00:53 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	green@...uxhacker.ru
Cc:	devel@...verdev.osuosl.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Oleg Drokin <oleg.drokin@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/13] staging/lustre: Drop SEEK_* definition checks

On Thu, Jul 30, 2015 at 06:27:57PM -0400, green@...uxhacker.ru wrote:
> From: Oleg Drokin <green@...uxhacker.ru>
> 
> SEEK_DATA and SEEK_HOLE are always defined in the kernel,
> drop the definition checks
> 
> Signed-off-by: Oleg Drokin <oleg.drokin@...el.com>
> ---
>  .../lustre/lustre/include/linux/lustre_compat25.h  | 38 ----------------------
>  1 file changed, 38 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> index d0e8f3c..7d90999 100644
> --- a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> +++ b/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
> @@ -69,37 +69,6 @@
>  # define inode_dio_read(i)		atomic_inc(&(i)->i_dio_count)
>  /* inode_dio_done(i) use as-is for read unlock */
>  
> -static inline int
> -ll_quota_on(struct super_block *sb, int off, int ver, char *name, int remount)
> -{
> -	int rc;
> -
> -	if (sb->s_qcop->quota_on) {
> -		struct path path;
> -
> -		rc = kern_path(name, LOOKUP_FOLLOW, &path);
> -		if (!rc)
> -			return rc;
> -		rc = sb->s_qcop->quota_on(sb, off, ver
> -					    , &path
> -					   );
> -		path_put(&path);
> -		return rc;
> -	} else
> -		return -ENOSYS;
> -}
> -
> -static inline int ll_quota_off(struct super_block *sb, int off, int remount)
> -{
> -	if (sb->s_qcop->quota_off) {
> -		return sb->s_qcop->quota_off(sb, off
> -					    );
> -	} else
> -		return -ENOSYS;
> -}
> -
> -
> -

This code removal doesn't match up with the changelog text, so I can't
take this :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/