linux-kernel - Re: [Xen-devel] [PATCH v6 1/4] x86/xen: Probe target addresses in set_aliased

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55BB42B3.1040103@citrix.com>
Date:	Fri, 31 Jul 2015 10:41:07 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	"Borislav Petkov" <bp@...en8.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"security@...nel.org" <security@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	"Steven Rostedt" <rostedt@...dmis.org>,
	xen-devel <xen-devel@...ts.xen.org>, <stable@...r.kernel.org>,
	Jan Beulich <jbeulich@...e.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Subject: Re: [Xen-devel] [PATCH v6 1/4] x86/xen: Probe target addresses in
 set_aliased_prot before the hypercall

On 30/07/15 22:31, Andy Lutomirski wrote:
> The update_va_mapping hypercall can fail if the VA isn't present in
> the guest's page tables.  Under certain loads, this can result in an
> OOPS when the target address is in unpopulated vmap space.
> 
> While we're at it, add comments to help explain what's going on.
> 
> This isn't a great long-term fix.  This code should probably be
> changed to use something like set_memory_ro.

Reviewed-by: David Vrabel <david.vrabel@...rix.com>

Thanks.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/