[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAK-LDbLQXFtg7S6aQCJiTdt5VmTEx9MWEziD+VEkjKHBx+CL5g@mail.gmail.com>
Date: Fri, 31 Jul 2015 07:33:20 +0530
From: Vaishali Thakkar <vthakkar1994@...il.com>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: Patrick McHardy <kaber@...sh.net>,
Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
netfilter-devel@...r.kernel.org, coreteam@...filter.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: xtables: Add helper macro for xt_match boilerplate
On Thu, Jul 30, 2015 at 5:54 PM, Pablo Neira Ayuso <pablo@...filter.org> wrote:
> On Sun, Jul 26, 2015 at 05:27:37PM +0530, Vaishali Thakkar wrote:
>> For simple modules that contain a single xt_match without any
>> additional setup code then ends up being a block of duplicated
>> boilerplate. This patch adds a new macro, module_xt_match(),
>> which replaces the module_init()/module_exit() registrations with
>> template functions.
>
> I prefer not to use this macro, we may need to add something to the
> module_init()/module_exit() path in the future to these netfilter
> extensions and then we'll have to revert the follow up conversions
> patches that you will likely send.
Ok. This makes sense. I think in that case you can drop the patch.
Thank You.
> Thanks anyway.
--
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists