linux-kernel - Re: [PATCH v2] kthread: Export kthread functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1507311610180.3825@nanos>
Date:	Fri, 31 Jul 2015 16:14:14 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	yalin wang <yalin.wang2010@...il.com>
cc:	Neil Horman <nhorman@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Kershner <david.kershner@...sys.com>, tj@...nel.org,
	laijs@...fujitsu.com, nacc@...ux.vnet.ibm.com, mingo@...hat.com,
	open list <linux-kernel@...r.kernel.org>,
	jes.sorensen@...hat.com, sparmaintainer@...sys.com
Subject: Re: [PATCH v2] kthread: Export kthread functions


On Fri, 31 Jul 2015, Thomas Gleixner wrote:

> On Fri, 31 Jul 2015, yalin wang wrote:
> > it is optimised to 2 instructions ,
> > 
> > this is my patch, hope can be merged :
> 
> We are not exposing the internals of kthread management. Period.

And your 'optimization' is completely bogus:

Before your modification:

size kernel/built-in.o

   text	   data	    bss	    dec	    hex	filename
1091514	 141498  341928 1574940  18081c	../build/kernel/built-in.o

After:

   text	   data	    bss	    dec	    hex	filename
1091664  141498  341928 1575090  1808b2	../build/kernel/built-in.o

That's an increase of text size by 150 byte. Interesting optimization.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/