linux-kernel - Re: [PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55BB8898.7000909@maciej.szmigiero.name>
Date:	Fri, 31 Jul 2015 16:39:20 +0200
From:	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:	Markus Pargmann <mpa@...gutronix.de>
CC:	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	Timur Tabi <timur@...i.org>,
	Nicolin Chen <nicoleotsuka@...il.com>,
	Xiubo Li <Xiubo.Lee@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linuxppc-dev@...ts.ozlabs.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC

On 31.07.2015 07:46, Markus Pargmann wrote:
> On Thu, Jul 30, 2015 at 04:35:23PM +0200, Maciej S. Szmigiero wrote:
>> Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode.
>>
>> Signed-off-by: Maciej Szmigiero <mail@...iej.szmigiero.name>
>> ---
>>  sound/soc/fsl/fsl_ssi.c |   21 +++++++++++++++++++++
>>  1 files changed, 21 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
>> index 154bcf6..8e5ff5e 100644
>> --- a/sound/soc/fsl/fsl_ssi.c
>> +++ b/sound/soc/fsl/fsl_ssi.c
>> @@ -1460,6 +1460,27 @@ done:
>>  		_fsl_ssi_set_dai_fmt(&pdev->dev, ssi_private,
>>  				     ssi_private->dai_fmt);
>>  
>> +	if (fsl_ssi_is_ac97(ssi_private)) {
>> +		u32 ssi_idx;
>> +
>> +		ret = of_property_read_u32(np, "cell-index", &ssi_idx);
> 
> This property is not set anywhere in the imx* DTs.

That's right, but it is documented as required property in sound/fsl,ssi.txt:
> Required properties:
> (..)
> - cell-index:       The SSI, <0> = SSI1, <1> = SSI2, and so on.

> 
>> +		if (ret) {
>> +			dev_err(&pdev->dev, "cannot get SSI index property\n");
>> +			goto error_sound_card;
>> +		}
>> +
>> +		ssi_private->pdev =
>> +			platform_device_register_data(NULL,
>> +					"ac97-codec", ssi_idx, NULL, 0);
> 
> If you really want to create a device at this point you should use
> PLATFORM_DEVID_AUTO. I would prefer something where this is created in
> DT. On the other side it is a discoverable bus..

In the original implementation the codec was instantiated in DT but
the feedback was that this is wrong since devices on discoverable
buses shouldn't be in DT.

The platform device index is based on SSI index since the sound
card driver (fsl-asoc-card) has to know CODEC device name to identify
it in DAI links - as the only identification options seem to be either
DT node of CODEC or its device name.

That's why the (platform) device name has to be deterministic
if there is no mechanism to pass it from controller driver
to sound card driver.

> Regards,
> 
> Markus

Best regards,
Maciej Szmigiero

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/