linux-kernel - Re: [RFC PATCH 09/16] PM / hibernate: Reserve swsusp key and earse footprints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150731154303.GF2067@linux-rxt1.site>
Date:	Fri, 31 Jul 2015 23:43:03 +0800
From:	joeyli <jlee@...e.com>
To:	Pavel Machek <pavel@....cz>
Cc:	"Lee, Chun-Yi" <joeyli.kernel@...il.com>,
	linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org,
	linux-pm@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	Len Brown <len.brown@...el.com>,
	Josh Boyer <jwboyer@...hat.com>,
	Vojtech Pavlik <vojtech@...e.cz>,
	Matt Fleming <matt.fleming@...el.com>,
	Jiri Kosina <jkosina@...e.cz>, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [RFC PATCH 09/16] PM / hibernate: Reserve swsusp key and earse
 footprints

On Tue, Jul 28, 2015 at 02:35:23PM +0200, Pavel Machek wrote:
> Typo in patch subject.
> 
> > And for earsing footbprints, the codes in this patch remove setup
> 
> And two typos here.
>

Sorry for subject and above typos, I will fix it.
Thanks.
 
> > data that carried swsusp key, and clean the memory space that
> 
> And don't call it swsusp. Please fix globally.
> 

OK~
								
> > +++ b/arch/x86/power/hibernate_keys.c
> > @@ -0,0 +1,79 @@
> > +/* Swsusp keys handler
> > + *
> > + * Copyright (C) 2015 SUSE Linux Products GmbH. All rights
> 
> Are you sure?
> 

Thank for your finding here, I will change the Copyright to me with my
company mail address.

> > +static int __init init_hibernate_keys(void)
> > +{
> > +	struct swsusp_keys *keys;
> > +	int ret = 0;
> > +
> > +	if (!keys_phys_addr)
> > +		return -ENODEV;
> > +
> > +	keys = early_memremap(keys_phys_addr, sizeof(struct swsusp_keys));
> > +
> > +	/* Copy swsusp keys to a allocated page */
> > +	swsusp_keys = (struct swsusp_keys *)get_zeroed_page(GFP_KERNEL);
> > +	if (swsusp_keys) {
> > +		*swsusp_keys = *keys;
> > +	} else {
> > +		pr_err("PM: Allocate swsusp keys page failed\n");
> > +		ret = -ENOMEM;
> > +	}
> > +
> > +	/* Earse keys data no matter copy success or failed */
> > +	memset(keys, 0, sizeof(struct swsusp_keys));
> > +	early_memunmap(keys, sizeof(struct swsusp_keys));
> > +	memblock_free(keys_phys_addr, sizeof(struct swsusp_keys));
> > +	keys_phys_addr = 0;
> > +
> > +	return ret;
> > +}
> > +
> > +late_initcall(init_hibernate_keys);
> 
> init_hibernation_keys.
> 
> 
> 								Pavel

I will change the function name.


Thanks a lot!
Joey Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/