linux-kernel - Re: [PATCH v5 1/4] bpf: Make the bpf_prog_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55BBA414.7040106@plumgrid.com>
Date:	Fri, 31 Jul 2015 09:36:36 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Kaixu Xia <xiakaixu@...wei.com>, davem@...emloft.net,
	acme@...nel.org, mingo@...hat.com, a.p.zijlstra@...llo.nl,
	masami.hiramatsu.pt@...achi.com, jolsa@...nel.org,
	daniel@...earbox.net
Cc:	wangnan0@...wei.com, linux-kernel@...r.kernel.org,
	pi3orama@....com, hekuang@...wei.com, netdev@...r.kernel.org
Subject: Re: [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic

On 7/31/15 4:59 AM, Kaixu Xia wrote:
> According to the comments from Daniel, rewrite part of
> the bpf_prog_array map code and make it more generic.
> So the new perf_event_array map type can reuse most of
> code with bpf_prog_array map and add fewer lines of
> special code.
>
> Tested the samples/bpf/tracex5 after this patch:
> 	$ sudo ./tracex5
> 	...
> 	dd-1051  [000] d...    26.682903: : mmap
> 	dd-1051  [000] d...    26.698348: : syscall=102 (one of get/set uid/pid/gid)
> 	dd-1051  [000] d...    26.703892: : read(fd=0, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.705847: : write(fd=1, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.707914: : read(fd=0, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.710988: : write(fd=1, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.711865: : read(fd=0, buf=000000000078c010, size=512)
> 	dd-1051  [000] d...    26.712704: : write(fd=1, buf=000000000078c010, size=512)
> 	...

the commit log doesn't really need these test results.
Also first paragraph is meaningless without prior history.
Please reword it, so it clearly says what this patch is doing and why.
Anyone reading it years later should be able to understand.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/