linux-kernel - Re: [PATCH V3 12/16] PM / OPP: add dev_pm_opp_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150731061023.GL3159@codeaurora.org>
Date:	Thu, 30 Jul 2015 23:10:23 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Rafael Wysocki <rjw@...ysocki.net>, linaro-kernel@...ts.linaro.org,
	linux-pm@...r.kernel.org, rob.herring@...aro.org,
	arnd.bergmann@...aro.org, nm@...com, broonie@...nel.org,
	mturquette@...libre.com, Sudeep.Holla@....com,
	viswanath.puttagunta@...aro.org, l.stach@...gutronix.de,
	thomas.petazzoni@...e-electrons.com,
	linux-arm-kernel@...ts.infradead.org, ta.omasab@...il.com,
	kesavan.abhilash@...il.com, khilman@...aro.org,
	santosh.shilimkar@...cle.com, b.zolnierkie@...sung.com,
	Tomasz Figa <tomasz.figa@...il.com>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Thomas Abraham <thomas.ab@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <len.brown@...el.com>,
	open list <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH V3 12/16] PM / OPP: add dev_pm_opp_is_turbo() helper

On 07/29, Viresh Kumar wrote:
> +bool dev_pm_opp_is_turbo(struct dev_pm_opp *opp)
> +{
> +	struct dev_pm_opp *tmp_opp;
> +
> +	opp_rcu_lockdep_assert();
> +
> +	tmp_opp = rcu_dereference(opp);
> +	if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available) {

IS_ERR_OR_NULL already has unlikely inside it on the error
pointer path so it seems redundant here.

Otherwise

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/