linux-kernel - Re: [PATCH 3.2 058/221] debugfs: leave freeing a symlink body until inode eviction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1438455539.3225.29.camel@decadent.org.uk>
Date:	Sat, 01 Aug 2015 19:58:59 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Luis Henriques <luis.henriques@...onical.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Al Viro <viro@...iv.linux.org.uk>,
	Joseph Salisbury <joseph.salisbury@...onical.com>,
	Jamie Strandboge <jamie.strandboge@...onical.com>
Subject: Re: [PATCH 3.2 058/221] debugfs: leave freeing a symlink body until
 inode eviction

On Tue, 2015-06-16 at 17:33 +0100, Luis Henriques wrote:
> On Tue, May 05, 2015 at 02:16:39AM +0100, Ben Hutchings wrote:
[...]
> > [bwh: Backported to 3.2:
> >  - Plumb in debugfs_super_operations, which we didn't previously 
> > define
> 
> It looks like this is introducing a regression[1].  Basically, simply
> running df shows an error:
> 
>   df: `/sys/kernel/debug': Function not implemented
> 
> Doing 'strace df' shows the following:
> 
>   statfs64("/sys/kernel/debug", 84, 0xbfddc6bc) = -1 ENOSYS (Function 
> not implemented)
> 
> A quick test shows that adding '.statfs = simple_statfs' in the
> debugfs_super_operations struct fixes the problem, but I'm not sure
> that's the right thing to do.
[...]

It looks right to me.  I've queued up this change; thanks a lot.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of them.


Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)