linux-kernel - Re: [RFC] alpha: use asm-generic/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55BC1A1F.4090702@roeck-us.net>
Date:	Fri, 31 Jul 2015 18:00:15 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>, rth@...ddle.net
CC:	ink@...assic.park.msu.ru, mattst88@...il.com, will.deacon@....com,
	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
	paul.gortmaker@...driver.com, mingo@...nel.org,
	linux-next@...r.kernel.org, "Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [RFC] alpha: use asm-generic/io.h

On 07/31/2015 05:38 PM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@...e.com>
>
> Since alpha does not include asm-generic/io.h it would mean
> alpha folks have to always carefully monitor asm-generic patches
> and before they get merged make sure their own arch implementation
> solution gets added. By using asm-generic/io.h alpha gets sensible
> defaults, in this case ioremap_uc() would be one example, where
> by default it would return NULL, so not implemented. When alpha
> folks get a chance then they can add the appropriate
> implementation.
>
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Signed-off-by: Luis R. Rodriguez <mcgrof@...e.com>

Doesn't work. Gives me lots of duplicate symbols.

Guenter

> ---
>
> The easy solution *for now* is to just do:
>
> #define ioremap_uc ioremap_nocache
>
> *But* that would have to be done for any other asm-generic/io.h collateral
> evolution, this on the other hand, would get it right for alpha from the
> get-go -- so I ask -- can this please be tested and if it is OK then consider
> it be merged?
>
> If we can't add asm-generic/io.h then the above define replacement would
> be the way to go.
>
>   arch/alpha/include/asm/io.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h
> index f05bdb4b1cb9..16a5bda42750 100644
> --- a/arch/alpha/include/asm/io.h
> +++ b/arch/alpha/include/asm/io.h
> @@ -581,4 +581,6 @@ extern void outsl (unsigned long port, const void *src, unsigned long count);
>
>   #endif /* __KERNEL__ */
>
> +#include <asm-generic/io.h>
> +
>   #endif /* __ALPHA_IO_H */
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/